Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double slash in redirect URL redirect location #1515

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Fix double slash in redirect URL redirect location #1515

merged 5 commits into from
Mar 17, 2023

Conversation

AndrewDryga
Copy link
Collaborator

Closes #1514

@AndrewDryga AndrewDryga added the kind/bug Something isn't working label Mar 17, 2023
@coveralls
Copy link

coveralls commented Mar 17, 2023 •
edited

Pull Request Test Coverage Report for Build a2a7c4a1110995c96ee6d5b4dd0a26ccf31b0244-PR-1515

  • 13 of 14 (92.86%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 66.996%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/fz_http/lib/fz_http/validator.ex 6 7 85.71%
Totals Coverage Status
Change from base Build 80b20e01268f8992fb040a5211263c822ddf7c1d: 0.09%
Covered Lines: 1697
Relevant Lines: 2533
💛 - Coveralls

jamilbk
jamilbk previously approved these changes Mar 17, 2023
View reviewed changes
@AndrewDryga
Ensure external_url always has trailing slash and stop using Path.join()
3e24c0d 
Path.join removes trailing slashes which is invalid behavior for urls
@AndrewDryga AndrewDryga merged commit c5a090f into master Mar 17, 2023
@AndrewDryga AndrewDryga deleted the andrew/redirect_uri_double_slash branch March 17, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk left review comments

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@AndrewDryga @coveralls @jamilbk