Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double slash in redirect URL redirect location #1515

Merged
merged 5 commits into from
Mar 17, 2023
Merged

Fix double slash in redirect URL redirect location #1515

merged 5 commits into from
Mar 17, 2023

Commits on Mar 17, 2023

  1. Fix double slash in redirect URL redirect location

    @AndrewDryga
    AndrewDryga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    487b489 View commit details
    Browse the repository at this point in the history

  2. Ensure external_url always has trailing slash and stop using Path.join() 

    Path.join removes trailing slashes which is invalid behavior for urls
    @AndrewDryga
    AndrewDryga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    3e24c0d View commit details
    Browse the repository at this point in the history

  3. run formatter

    @AndrewDryga
    AndrewDryga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    9c8f644 View commit details
    Browse the repository at this point in the history

  4. Change credo setting

    @AndrewDryga
    AndrewDryga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    2da2c1f View commit details
    Browse the repository at this point in the history

  5. Also fix trailing slash in code sample

    @AndrewDryga
    AndrewDryga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a2a7c4a View commit details
    Browse the repository at this point in the history