fix(apple): spawn new thread for runtime to prevent it from being taken down #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
thomaseizinger
requested changes
Mar 14, 2024
thomaseizinger
approved these changes
Mar 14, 2024
Performance Test ResultsTCP
UDP
|
@thomaseizinger I was planning to do this in another PR :) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I already sent one! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
Same as #4141 but for Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the current thread in apple was causing a crashloop, since connlib's thread was taken down by the network extension after
WrappedSession::connectreturned.Now we force the runtime to create the thread to prevent it from being taken down.