refactor(linux-client): package systemd unit for IPC service #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this specific case it doesn't hurt, but when we go to make the Deb package, the ID can't go there.
Closes <#4461>
…one into refactor/move-firezone-id
Also fix the names of the executables. I couldn't get the IPC service exe into `/usr/lib` unfortunately. We'd have to work around Tauri's deb bundling to do that, and that can wait. Refs #4531
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
…refactor/package-systemd-service
…d-service Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
ReactorScram
commented
Apr 24, 2024
| @@ -84,7 +84,7 @@ jobs: | |||
| - name: Sign the MSI | |||
| if: ${{ runner.os == 'Windows' }} | |||
| shell: bash | |||
| run: ../../scripts/build/sign.sh ../target/release/bundle/msi/Firezone_${{ env.VERSION }}_x64_en-US.msi | |||
| run: ../../scripts/build/sign.sh ../target/release/bundle/msi/firezone-client-gui_${{ env.VERSION }}_x64_en-US.msi | |||
There was a problem hiding this comment.
This should be fine since the rename script still renames it to $BINARY_DEST_PATH
conectado
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns some of the internal names with #4531, but it shouldn't break the externally-visible things like package names or permalinks.