fix(snownet): don't nominate discarded candidates #4806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output |
thomaseizinger
changed the title
Performance Test ResultsTCP
UDP
|
jamilbk
approved these changes
Apr 28, 2024
|
Updating with |
jamilbk
approved these changes
Apr 29, 2024
|
After some more testing it looks like this is causing #4826 |
jamilbk
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When candidates are being invalidated in str0m, they internally set a
discardedflag. This flag was not considered when a candidate that was previously discarded was added again. This can happen when a client roams back to their old network, i.e. going from Ethernet to WiFi and back.In that case, str0m would still form new pairs using the old discarded candidate which would also eventually get nominated as part of a pair. This would lead to a panic in snownet when we try to find the nominated local candidate as we filter by non-discarded candidates there.
Related: algesten/str0m#508.
Resolves: #4736.