Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(snownet): don't nominate discarded candidates" #4838

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Apr 30, 2024

Reverts #4806

refs #4826

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Apr 30, 2024 9:42pm

@jamilbk jamilbk enabled auto-merge April 30, 2024 21:42
@jamilbk jamilbk changed the title Revert "fix(snownet): don't nominate discarded candidates" revert: "fix(snownet): don't nominate discarded candidates" Apr 30, 2024
@jamilbk jamilbk disabled auto-merge April 30, 2024 21:43
@jamilbk jamilbk merged commit f322a4e into main Apr 30, 2024
63 of 64 checks passed
@jamilbk jamilbk deleted the revert-4806-deps/bump-str0m-0.5.1 branch April 30, 2024 21:43
Copy link

Terraform Cloud Plan Output

Plan: 20 to add, 16 to change, 33 to destroy.

Terraform Cloud Plan

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 245.0 MiB (+1%) 247.4 MiB (+1%) 368 (+29%)
direct-tcp-server2client 241.6 MiB (-1%) 242.9 MiB (-1%) 233 (+19%)
relayed-tcp-client2server 222.7 MiB (-2%) 223.4 MiB (-2%) 235 (-13%)
relayed-tcp-server2client 232.9 MiB (-2%) 233.4 MiB (-2%) 412 (-8%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.03ms (-41%) 43.03% (-4%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (+26%) 21.74% (-1%)
relayed-udp-client2server 500.0 MiB (-0%) 0.05ms (+108%) 53.59% (-7%)
relayed-udp-server2client 500.0 MiB (+0%) 0.04ms (+99%) 40.15% (-6%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants