refactor(gui-client/linux): use the same systemd service file in CI as in production #4832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactorScram
added
area/ci
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
ReactorScram
commented
Apr 30, 2024
| @@ -38,6 +38,7 @@ UMask=077 | |||
| Environment="FIREZONE_DNS_CONTROL=systemd-resolved" | |||
| Environment="LOG_DIR=/var/log/dev.firezone.client" | |||
| Environment="RUST_LOG=info" | |||
| EnvironmentFile="/etc/default/firezone-client-ipc" | |||
There was a problem hiding this comment.
The ID and token could actually go in this type of file for the headless Clients, if we end up setting them up as deb packages and put the systemd service file in /usr/lib
jamilbk
approved these changes
May 1, 2024
|
Here's what I checked:
These others remain:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 1, 2024
…adable (#4825) ```[tasklist] # Before merging - [x] Add CI test to check that the Unix domain socket is owned by `root:firezone` (#4832 will do this) ``` This allows the GUI (running as a normal user who belongs to the `firezone` group) to read back the connlib logs and export them in the zip file. <img width="716" alt="image" src="https://github.com/firezone/firezone/assets/13400041/59cb7cc5-fd6a-4b27-a311-1b9c56b7b23e">
|
It kinda looks like normal users already have permission to send requests to the resolve service, it just refuses anything destructive if you're not root. If I knew more about d-bus this might make sense to me but unfortunately it doesn't 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will keep the files from going out of sync.
This PR also checks that the IPC service creates the IPC socket with
root:firezoneas the owner and group, when running under systemd.