chore(gui-client/linux): fix group name, firezone should be firezone-client
#4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactorScram
added
kind/chore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
ReactorScram
commented
May 3, 2024
| 1. Check the IP again | ||
| 1. Export the logs | ||
| 1. Expect `zipinfo` to show |
There was a problem hiding this comment.
Oops, forgot to finish this part. I'll get it before it merges
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 7, 2024
```[tasklist] ### Before merging - [x] (FAILED) Test CI deb on Ubuntu 24.04 #4883 - [x] Wait for everything else to merge: #3884 - [x] Fix #4889 - [x] Fix #4890 - [x] Test on Ubuntu 20.04 (683bddc passed) - [x] Test on Ubuntu 22.04 (683bddc passed) - [x] diff between main and 683bddc to make sure nothing in the code changed - [ ] Someone other than me should give it a once-over. `intended_behavior.md` has the manual smoke test I've been doing on it. Install script is <https://github.com/firezone/firezone/blob/a943a9dba1797317327563bb2de48e22f239175a/scripts/firezone-client-gui-install.sh> Deb package from CI is <https://github.com/firezone/firezone/actions/runs/8972824465/artifacts/1477261361> ```
| .context("can't get group by name")? | ||
| .context("firezone group must exist on the system")?; | ||
| .context("`{FIREZONE_GROUP}` group must exist on the system")?; |
There was a problem hiding this comment.
@ReactorScram This string interpolation does not work, you need format! for that :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improved the manual testing checklist a little