Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(gui-client/linux): publish deb package in the release #4876

Merged
merged 4 commits into from
May 7, 2024
Merged

ci(gui-client/linux): publish deb package in the release #4876

merged 4 commits into from
May 7, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented May 1, 2024 •
edited

Before merging

Edit tasklist title
Beta Give feedback Tasklist Before merging, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. (FAILED) Test CI deb on Ubuntu 24.04 bug(gui-client/linux): The Tauri GUI Client doesn't work on Ubuntu 24.04 #4883
    Options
  2. Wait for everything else to merge: Before publishing Linux GUI client #3884
    Options
  3. Fix chore(gui-client/linux): fix group name, firezone should be firezone-client #4889
    Options
  4. Fix chore(gui-client/linux): fix single-instance #4890
    Options
  5. Test on Ubuntu 20.04 (683bddc0b passed)
    Options
  6. Test on Ubuntu 22.04 (683bddc0b passed)
    Options
  7. diff between main and 683bddc0b to make sure nothing in the code changed
    Options
  8. Someone other than me should give it a once-over. intended_behavior.md has the manual smoke test I've been doing on it. Install script is https://github.com/firezone/firezone/blob/a943a9dba1797317327563bb2de48e22f239175a/scripts/firezone-client-gui-install.sh Deb package from CI is https://github.com/firezone/firezone/actions/runs/8972824465/artifacts/1477261361
    Options

@ReactorScram ReactorScram added area/ci Changes to the CI pipeline / Github Actions area/tauri_client The Windows and Linux Tauri GUI clients labels May 1, 2024
@ReactorScram ReactorScram added this to the 05/24 milestone May 1, 2024
@ReactorScram ReactorScram self-assigned this May 1, 2024
@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 11:16pm

@ReactorScram ReactorScram mentioned this pull request May 1, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.1 MiB (+0%) 242.3 MiB (+0%) 163 (-37%)
direct-tcp-server2client 239.3 MiB (-2%) 240.7 MiB (-2%) 173 (-67%)
relayed-tcp-client2server 228.9 MiB (+2%) 229.9 MiB (+2%) 304 (+22%)
relayed-tcp-server2client 237.5 MiB (+0%) 238.0 MiB (+0%) 360 (-26%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 499.6 MiB (-0%) 0.51ms (+1127%) 44.76% (-2%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-56%) 21.94% (+12%)
relayed-udp-client2server 500.0 MiB (-0%) 0.03ms (-56%) 54.56% (-1%)
relayed-udp-server2client 500.0 MiB (-0%) 0.01ms (-77%) 38.80% (-1%)

@ReactorScram ReactorScram marked this pull request as ready for review May 1, 2024 21:15
conectado
conectado approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@conectado conectado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'm a bit out of the loop, I think, github-actions doesn't have a native way to release artifacts do we need to use github's cli?

@ReactorScram
Copy link
Collaborator Author

I'm not aware of any. I think we've been using the GitHub CLI as long as I've been here

@ReactorScram ReactorScram added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@ReactorScram
Copy link
Collaborator Author

Blocked on #4898

@ReactorScram ReactorScram added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 6, 2024
@ReactorScram ReactorScram added this pull request to the merge queue May 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
@ReactorScram
ci(gui-client/linux): publish deb package in the release (#4876)
fd28153 
```[tasklist]
### Before merging
- [x] (FAILED) Test CI deb on Ubuntu 24.04 #4883
- [x] Wait for everything else to merge: #3884
- [x] Fix #4889
- [x] Fix #4890
- [x] Test on Ubuntu 20.04 (683bddc passed)
- [x] Test on Ubuntu 22.04 (683bddc passed)
- [x] diff between main and 683bddc to make sure nothing in the code changed
- [ ] Someone other than me should give it a once-over. `intended_behavior.md` has the manual smoke test I've been doing on it. Install script is <https://github.com/firezone/firezone/blob/a943a9dba1797317327563bb2de48e22f239175a/scripts/firezone-client-gui-install.sh> Deb package from CI is <https://github.com/firezone/firezone/actions/runs/8972824465/artifacts/1477261361> 
```
@ReactorScram ReactorScram removed this pull request from the merge queue due to a manual request May 6, 2024
@ReactorScram ReactorScram added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@jamilbk jamilbk added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 7870dca May 7, 2024
135 checks passed
@jamilbk jamilbk deleted the ci/publish-linux-gui-deb branch May 7, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conectado conectado conectado approved these changes

@jamilbk jamilbk Awaiting requested review from jamilbk

Assignees

@ReactorScram ReactorScram

Labels
area/ci Changes to the CI pipeline / Github Actions area/tauri_client The Windows and Linux Tauri GUI clients
Projects
None yet
Milestone
06/24
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ReactorScram @conectado @jamilbk