Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(windows): fix unused deps static analysis #4898

Merged
merged 2 commits into from
May 6, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented May 6, 2024

Fixes these type of errors: https://github.com/firezone/firezone/actions/runs/8973627864/job/24644251114

Using --no-self-update as recommended here: rust-lang/rustup#2415 (comment)

Probably was a regression introduced by a version bump in the Github runner's Rustup or something

@ReactorScram ReactorScram self-assigned this May 6, 2024
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 7:19pm

Copy link

github-actions bot commented May 6, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 26 to destroy.

Terraform Cloud Plan

@ReactorScram ReactorScram marked this pull request as ready for review May 6, 2024 19:28
Copy link

github-actions bot commented May 6, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.1 MiB (+2%) 243.5 MiB (+2%) 266 (+5%)
direct-tcp-server2client 243.8 MiB (+0%) 245.1 MiB (+0%) 244 (-36%)
relayed-tcp-client2server 226.8 MiB (+3%) 227.8 MiB (+3%) 256 (+24%)
relayed-tcp-server2client 231.9 MiB (-3%) 232.6 MiB (-3%) 326 (-29%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.05ms (+51%) 42.33% (+4%)
direct-udp-server2client 500.0 MiB (+0%) 0.02ms (-9%) 22.57% (+29%)
relayed-udp-client2server 500.0 MiB (+0%) 0.02ms (+0%) 53.05% (-8%)
relayed-udp-server2client 499.9 MiB (-0%) 0.02ms (-14%) 44.09% (+23%)

@ReactorScram ReactorScram added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@ReactorScram
Copy link
Collaborator Author

Elixir unit test failed, I'll assume that's just flakiness https://github.com/firezone/firezone/actions/runs/8974954614/job/24648477214

@ReactorScram ReactorScram added this pull request to the merge queue May 6, 2024
@jamilbk
Copy link
Member

jamilbk commented May 6, 2024

Elixir unit test failed, I'll assume that's just flakiness https://github.com/firezone/firezone/actions/runs/8974954614/job/24648477214

Yeah, adding another ref to #3838

Merged via the queue into main with commit 8b9df9a May 6, 2024
135 checks passed
@ReactorScram ReactorScram deleted the ci/fix-windows-analysis branch May 6, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants