-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(headless-client): remove "linux-client" alias #4933
Conversation
I'm going to want a well-known dir that the Windows IPC service writes logs to, and that the Windows GUI can pick them up from. I don't know how I did this for Linux last week, but it should probably be in here too.
…one into chore/windows-service-poc
This has a known gap where theoretically the GUI could sign in while the service is hung in startup, and then the service would wipe out the GUI's DNS rules. The workaround for that would be to restart the GUI, but in practice I think this is almost impossible, Windows would have to give the service no CPU time while the user was signing in, then the user would have to immediately open Firezone before the service got running. Closes #4899
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…tor/remove-linux-client
Terraform Cloud Plan Output
|
Performance Test ResultsTCP
UDP
|
@bmanifold Would this PR break your monitoring VM? Since there will be a headless Client for Windows in the near future, I'm trying to slowly remove the platform name from the exes. "linux-client" is currently just another name for "headless-client". |
It looks like you've already updated the place that would need to change for the monitoring VM. As long as the new binary runs in the same way the |
Okay. The thing I said about the explicit subcommand is actually for a different PR I had mixed up. So this is fine, it's blocking on #4903 |
Actually it's not blocked on that PR. Just rebased on main. |
@jamilbk should we force this even though the compat tests didn't all pass? I don't think I have that permission |
Yeah if they're expected to fail, and main is expected to stay green, we can merge. Added permission for you |
Yeah should be good. I think they're failing because my new code is looking for If I'm wrong and main breaks I'll open a PR to revert this. |
Is this worth it?
Before merging