Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: cache webview installer #4935

Merged
merged 2 commits into from
May 9, 2024
Merged

ci: cache webview installer #4935

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aa39c3
cache webview installer
jamilbk May 9, 2024
8210ae3
Add arch
jamilbk May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/actions/setup-tauri/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,14 @@ runs:
if: ${{ runner.os == 'Linux' }}
run: sudo apt-get install at-spi2-core xvfb
shell: bash
- name: Download WebView2 bootstrapper
- uses: actions/cache@v4
if: ${{ runner.os == 'Windows' }}
id: cache-webview2-installer
with:
path: WebView2Installer.exe
key: ${{ runner.os }}-webview2-installer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arch should be here too, it'll save a little trouble whenever aarch64 Windows comes up.

Most other cache keys, like for Rust, are OS + arch, right?

- name: Download WebView2 bootstrapper
if: ${{ runner.os == 'Windows' && steps.cache-webview2-installer.outputs.cache-hit != 'true' }}
# This is the "Evergreen" bootstrapper from Microsoft
# <https://developer.microsoft.com/en-us/microsoft-edge/webview2/?form=MA13LH#download>
# Unfortunately, this makes the test non-deterministic.
Expand Down
Loading