Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: cache webview installer #4935

Merged
merged 2 commits into from
May 9, 2024
Merged

ci: cache webview installer #4935

merged 2 commits into from
May 9, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 9, 2024

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:22pm

@jamilbk jamilbk requested a review from ReactorScram May 9, 2024 15:59
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

ReactorScram
ReactorScram requested changes May 9, 2024
View reviewed changes
.github/actions/setup-tauri/action.yml Outdated
id: cache-webview2-installer
with:
path: WebView2Installer.exe
key: ${{ runner.os }}-webview2-installer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arch should be here too, it'll save a little trouble whenever aarch64 Windows comes up.

Most other cache keys, like for Rust, are OS + arch, right?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 242.5 MiB (-0%) 244.1 MiB (-0%) 398 (+61%)
direct-tcp-server2client 248.1 MiB (+1%) 249.9 MiB (+1%) 573 (+74%)
relayed-tcp-client2server 227.2 MiB (+0%) 228.0 MiB (+1%) 266 (+20%)
relayed-tcp-server2client 238.3 MiB (+0%) 239.4 MiB (+0%) 401 (+29%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.03ms (-56%) 44.17% (-7%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-75%) 21.09% (-9%)
relayed-udp-client2server 500.0 MiB (+0%) 0.02ms (-20%) 57.68% (+2%)
relayed-udp-server2client 500.0 MiB (+0%) 0.04ms (+423%) 47.60% (+16%)

@jamilbk jamilbk requested a review from ReactorScram May 9, 2024 16:30
ReactorScram
ReactorScram approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it works!

@jamilbk jamilbk added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit c3b5768 May 9, 2024
135 checks passed
@jamilbk jamilbk deleted the fix/flaky-webview2 branch May 9, 2024 17:21
@ReactorScram
Copy link
Collaborator

https://github.com/firezone/firezone/actions/runs/9024515614/job/24798528039#step:4:57

Even though the cache worked, it seems like the installer just hangs sometimes. On Windows 2019 it finished in 1 minutes, on 2022 it's been going for 30 minutes.

@ReactorScram
Copy link
Collaborator

Might not be our fault MicrosoftEdge/WebView2Feedback#4443

I didn't notice this before, and now it's happening on any job that has setup-tauri, so I think it could be a regression in the WebView code, and I've only seen it on Windows 2022 so far. (static analysis and build-tauri)

ReactorScram added a commit that referenced this pull request May 13, 2024
@ReactorScram
ci(windows): time out the WebView2 install after 5 minutes
88ab38b 
It typically takes about 1 minute to run in CI. We don't have any leads
on fixing this issue, and it may be a regression in a recent release of
WebView2. #4935
@ReactorScram ReactorScram mentioned this pull request May 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
@ReactorScram
ci(windows): time out the WebView2 install after 5 minutes (#4981)
7bf1003 
It typically takes about 1 minute to run in CI. We don't have any leads
on fixing this issue, and it may be a regression in a recent release of
WebView2. #4935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReactorScram ReactorScram ReactorScram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamilbk @ReactorScram