Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(windows): time out the WebView2 install after 5 minutes #4981

Merged
merged 7 commits into from
May 13, 2024

Conversation

ReactorScram
Copy link
Collaborator

It typically takes about 1 minute to run in CI. We don't have any leads on fixing this issue, and it may be a regression in a recent release of WebView2. #4935

It typically takes about 1 minute to run in CI. We don't have any leads
on fixing this issue, and it may be a regression in a recent release of
WebView2. #4935
@ReactorScram ReactorScram self-assigned this May 13, 2024
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 10:09pm

@github-actions github-actions bot added the area/ci Changes to the CI pipeline / Github Actions label May 13, 2024
@ReactorScram ReactorScram marked this pull request as ready for review May 13, 2024 21:17
Copy link

github-actions bot commented May 13, 2024

Terraform Cloud Plan Output

Plan: 16 to add, 15 to change, 16 to destroy.

Terraform Cloud Plan

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 239.2 MiB (-1%) 240.9 MiB (-1%) 333 (+80%)
direct-tcp-server2client 241.7 MiB (-1%) 242.9 MiB (-1%) 99 (-59%)
relayed-tcp-client2server 233.7 MiB (+2%) 234.3 MiB (+2%) 190 (+8%)
relayed-tcp-server2client 240.6 MiB (+0%) 241.4 MiB (+0%) 362 (-10%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.03ms (+48%) 45.57% (+12%)
direct-udp-server2client 500.0 MiB (+0%) 0.04ms (+131%) 20.49% (+1%)
relayed-udp-client2server 500.0 MiB (-0%) 0.01ms (-72%) 55.57% (-2%)
relayed-udp-server2client 500.0 MiB (+0%) 0.04ms (+54%) 39.95% (-8%)

@ReactorScram ReactorScram added this pull request to the merge queue May 13, 2024
@ReactorScram
Copy link
Collaborator Author

I couldn't get that timeout-minutes to work in the action itself, so I did it in the workflows wherever they call into setup-tauri.

I also tried doing the timeout directly in Powershell and it worked on my local VM but said something about Start-Process returning a null value in CI.

Merged via the queue into main with commit 7bf1003 May 13, 2024
135 checks passed
@ReactorScram ReactorScram deleted the ci/timeout-webview-install branch May 13, 2024 22:57
@ReactorScram
Copy link
Collaborator Author

This might be the upstream issue MicrosoftEdge/WebView2Feedback#4443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Changes to the CI pipeline / Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants