Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setup() builder to avoid spurious analog reports from device. #22

Merged
merged 1 commit into from Jun 2, 2018

Conversation

ethanjli
Copy link
Contributor

@ethanjli ethanjli commented May 29, 2018

As discussed in firmata/ConfigurableFirmata#81, this prevents spurious analog pin reporting behavior at the end of setup. I was able to run two basic tests of the sketch created by examples/demo.js on an Arduino Uno:

I wasn't sure how to best rename the unit test for this change - please let me know if a less literal test name would be more appropriate.

@soundanalogous soundanalogous merged commit c3e3cb2 into firmata:master Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants