Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An async write operation completion problem #154

Closed
rwaldron opened this issue Mar 22, 2017 · 0 comments
Closed

An async write operation completion problem #154

rwaldron opened this issue Mar 22, 2017 · 0 comments

Comments

@rwaldron
Copy link
Collaborator

The problem begins here: rwaldron/johnny-five#1306 (important to read through to my findings at the end).

Summary points:

  • serialport writing is non-blocking
  • firmata.js dependent programs may want to do cleanup tasks before exiting.
  • firmata.js needs a simple way to signal that writes are:
    • pending
    • complete
  • incrementing and decrementing a counter is simple way to achieve such signaling.
rwaldron added a commit that referenced this issue Mar 22, 2017
…letions. Fixes #154

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron added a commit that referenced this issue Mar 22, 2017
…letions. Fixes #154

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron added a commit that referenced this issue Mar 23, 2017
…letions. Fixes #154

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron added a commit that referenced this issue Mar 23, 2017
…letions. Fixes #154

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
rwaldron added a commit that referenced this issue Mar 30, 2017
Introduces writeToTransport as a wrapper for tracking writes and completions. Fixes #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant