Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Dutch translation and minor improvements #386

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

PanderMusubi
Copy link
Contributor

No description provided.

@PanderMusubi
Copy link
Contributor Author

closes #109

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to do this :)

  • Please add nl to the languages entry in _config.yml so that it will result:

languages: ["en", "zh-cn", "id", "nl"]

  • We need a Dutch speaker to review the translated strings.

_i18n/nl.yml Outdated Show resolved Hide resolved
@erciccione erciccione mentioned this pull request Apr 23, 2024
@PanderMusubi PanderMusubi force-pushed the dutchtranslation branch 2 times, most recently from 793b0d6 to 56c5e09 Compare April 24, 2024 09:27
@PanderMusubi
Copy link
Contributor Author

I have a friend of mine review the translation. Other question, do we have a testing/staging environment for the website so the translation can be viewed in the resulting website? This would also be beneficial for more translations that will be added in the future or major changes which influence translations.

@justanwar
Copy link
Member

@PanderMusubi We are still trying to decide in #329.

A CI file already exists, but does not generate previews at the moment.

@erciccione
Copy link
Contributor

You can also run the website locally. See https://jekyllrb.com/docs/

@PanderMusubi
Copy link
Contributor Author

You can also run the website locally. See https://jekyllrb.com/docs/

Thanks, see also #389

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically ok, but would be better to have somebody review the translations.

@PanderMusubi
Copy link
Contributor Author

Perhaps find somebody via Discord?

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions come from a native Dutch speaker. I'm posting for them, but i do not speak the language.

_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Show resolved Hide resolved
_i18n/nl.yml Outdated Show resolved Hide resolved
_i18n/nl.yml Outdated Show resolved Hide resolved
PanderMusubi and others added 2 commits May 28, 2024 12:54
Co-authored-by: ErC <erciccione@users.noreply.github.com>
Co-authored-by: ErC <erciccione@users.noreply.github.com>
@PanderMusubi
Copy link
Contributor Author

I've processed the feedback. Thanks.

Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor fix and then looks ready for merge

_i18n/nl.yml Outdated Show resolved Hide resolved
@justanwar justanwar merged commit 4d85db2 into firoorg:master Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants