Fee estimation optimized #1004
Merged
Fee estimation optimized #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
force-pushed
the
fee_estimation_optimized
branch
from
9f06883
to
305d2d0
Compare
a-bezrukov
previously approved these changes
Apr 5, 2021
psolstice
requested changes
Apr 12, 2021
| // 956 is constant part, mainly Schnorr and Range proof, 2560 is for each sigma/aux data | ||
| // 83 assuming 1 jmint, 34 is the size of each normal vout, 10 is the size of empty transaction, 52 other constant parts | ||
| nBytes = 956 + 2560 * vOutputs.size() + 83 + CoinControlDialog::payAmounts.size() * 34 + 10 + 52; | ||
| nPayFee = CWallet::GetMinimumFee(nBytes, nTxConfirmTarget, mempool); |
There was a problem hiding this comment.
Does this formula take new Qk Schnorr proof into account?
We really need to create a set of functions to deal with size estimates and use it instead of such hardcoded estimates. Sooner or later we will end up with estimate which is too low and transactions will be rejected at mempool level.
There was a problem hiding this comment.
no, I will update this, I have implemented such function, but it works slow and is making coincontrol work laggy, may be better to include this for now. after some refactorings and optimizations may be such function will be useful.
psolstice
approved these changes
Apr 15, 2021
a-bezrukov
approved these changes
Apr 15, 2021
|
This pull request introduces 3 alerts when merging 1e30c81 into 72d824c - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.