Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range proof batch verification #1023

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Range proof batch verification #1023

merged 5 commits into from
Feb 15, 2022

Conversation

AaronFeickert
Copy link
Contributor

Adds support for batch verification of range proofs. Updates tests. Retains compatibility with existing function calls for verification of single proofs.

This code does not directly support batch verification of actual transactions, only the plumbing necessary to add this functionality later.

Review requested.

@lgtm-com
Copy link

lgtm-com bot commented May 2, 2021

This pull request introduces 3 alerts when merging d75c3d5 into c8f28bf - view on LGTM.com

new alerts:

  • 2 for Unused static function
  • 1 for Catching by value

@lgtm-com
Copy link

lgtm-com bot commented May 7, 2021

This pull request introduces 3 alerts when merging 25df2d0 into 677b54c - view on LGTM.com

new alerts:

  • 2 for Unused static function
  • 1 for Catching by value

@AaronFeickert AaronFeickert force-pushed the bp-batching branch 2 times, most recently from 3e6d879 to f6aa87a Compare May 17, 2021 23:05
@lgtm-com
Copy link

lgtm-com bot commented May 18, 2021

This pull request introduces 1 alert when merging f6aa87a into 677b54c - view on LGTM.com

new alerts:

  • 1 for Catching by value

@AaronFeickert AaronFeickert force-pushed the bp-batching branch 3 times, most recently from bbf9903 to ec0c149 Compare June 28, 2021 15:16
@AaronFeickert AaronFeickert force-pushed the bp-batching branch 4 times, most recently from 2b9d2cd to a2659a4 Compare July 12, 2021 18:00
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 2 alerts when merging a2659a4 into 8192c5f - view on LGTM.com

new alerts:

  • 2 for Unused static function

@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2021

This pull request introduces 2 alerts when merging d377fed into c4918fd - view on LGTM.com

new alerts:

  • 2 for Unused static function

@lgtm-com
Copy link

lgtm-com bot commented Jul 16, 2021

This pull request introduces 2 alerts when merging 4df4f35 into c4918fd - view on LGTM.com

new alerts:

  • 2 for Unused static function

@AaronFeickert AaronFeickert force-pushed the bp-batching branch 3 times, most recently from 149cc48 to 354b242 Compare July 23, 2021 01:31
@reubenyap reubenyap added this to the v0.14.9.0 ProgPOW milestone Aug 17, 2021
@AaronFeickert AaronFeickert marked this pull request as ready for review August 19, 2021 16:58
@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2021

This pull request fixes 5 alerts when merging 4c27634 into 460c17f - view on LGTM.com

fixed alerts:

  • 5 for Unused static function

@reubenyap reubenyap modified the milestones: v0.14.9.0 FiroPoW, v0.14.9.1 Maintenance Release Sep 26, 2021
@lgtm-com
Copy link

lgtm-com bot commented Dec 19, 2021

This pull request fixes 4 alerts when merging 3b1df8d into 738308b - view on LGTM.com

fixed alerts:

  • 4 for Unused static function

@levonpetrosyan93 levonpetrosyan93 mentioned this pull request Dec 26, 2021
Merged
@reubenyap reubenyap merged commit 26317fa into firoorg:master Feb 15, 2022
@AaronFeickert AaronFeickert deleted the bp-batching branch February 15, 2022 20:53
levonpetrosyan93 pushed a commit that referenced this pull request May 17, 2023
@AaronFeickert @levonpetrosyan93
Range proof batch verification (#1023)
33347e9 
* Range proof batch verification

* Namespace fixes

* Add legacy zero checks

* Update tests

* Add all relevant transaction versions to tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AaronFeickert @levonpetrosyan93 @reubenyap