Preventing hd counter reuse, Allow to spend such mints #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging d94f48b into 677b54c - view on LGTM.com new alerts:
|
levonpetrosyan93
changed the title
|
This pull request introduces 2 alerts when merging dc2fd38 into 677b54c - view on LGTM.com new alerts:
|
|
This pull request fixes 3 alerts when merging 52b3dd0 into e2c8db6 - view on LGTM.com fixed alerts:
|
|
This pull request introduces 2 alerts when merging 2a44cab into 8192c5f - view on LGTM.com new alerts:
|
psolstice
force-pushed
the
lelantus-payload
branch
from
a650e53
to
4a69aa5
Compare
|
This pull request introduces 2 alerts when merging 1c00b8d into 8f01f63 - view on LGTM.com new alerts:
|
psolstice
previously approved these changes
Aug 17, 2021
psolstice
approved these changes
Aug 17, 2021
|
This pull request fixes 3 alerts when merging 50a0c74 into f488a2a - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Lelantus mint creation there was missing a check if a sigma mint with the same private data already exists on chain, and due to that there were created lelantus mints with reused HD counter. The check added.
As during spend serial number use check was done on both sigma and lelantus used serial sets, such lelantus mints became unspendable, After HF block we are checking sigma serials only on sigma used serial set, and lelantus serials only on lelantus used serial set.