Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding private balance value into getBalance rpc result #1045

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

levonpetrosyan93
Copy link
Contributor

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jun 21, 2021

This pull request introduces 3 alerts when merging e99b0b9 into 237d229 - view on LGTM.com

new alerts:

  • 3 for Unused static function

@reubenyap reubenyap added this to the v0.14.7.1 milestone Jun 22, 2021
@reubenyap reubenyap added the bug label Jun 24, 2021
a-bezrukov
a-bezrukov previously approved these changes Jun 28, 2021
Copy link
Contributor

@psolstice psolstice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is instead of modifying existing RPC (and losing ability to get transparent balance with RPC call) we add another RPC to get private balance

@a-bezrukov a-bezrukov merged commit e3f929c into master Jul 5, 2021
@a-bezrukov a-bezrukov deleted the getbalance_fix branch July 5, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants