Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bip47 GUI fixes #1046

Merged
merged 17 commits into from
Jul 12, 2021
Merged

Bip47 GUI fixes #1046

merged 17 commits into from
Jul 12, 2021

Conversation

a-bezrukov
Copy link
Contributor

@a-bezrukov a-bezrukov commented Jun 23, 2021

PR intention

This is a series of GUI improvements:

  1. Improved sending to a RAP address workflow - removed showing the secret address, made impossible to send unless a notification tx confirmed.
  2. Implemented the receiving RAP address relabeling and RAP addresses creation during the wallet recover
  3. Renamed pcodes to be RAP addresses for RPCs
  4. Minor fixes - logging, naming
  5. Fixed the bug with subsequently accpeted blocks

@lgtm-com
Copy link

lgtm-com bot commented Jun 23, 2021

This pull request fixes 2 alerts when merging b65405a into 892c64e - view on LGTM.com

fixed alerts:

  • 2 for Unused static function

@reubenyap reubenyap added this to the v0.14.7.1 milestone Jun 24, 2021
@reubenyap reubenyap requested review from psolstice and levonpetrosyan93 and removed request for psolstice June 24, 2021 09:24
@reubenyap reubenyap added cosmetic GUI GUI related issues and removed cosmetic labels Jun 24, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2021

This pull request introduces 2 alerts when merging 243670c into e3f929c - view on LGTM.com

new alerts:

  • 2 for Declaration hides variable

@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2021

This pull request introduces 2 alerts when merging 63849ff into ed2bd7e - view on LGTM.com

new alerts:

  • 2 for Declaration hides variable

src/qt/walletmodel.cpp Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Jul 10, 2021

This pull request introduces 2 alerts when merging bc57040 into 99ee21d - view on LGTM.com

new alerts:

  • 2 for Declaration hides variable

src/qt/walletmodel.cpp Show resolved Hide resolved
@a-bezrukov a-bezrukov marked this pull request as draft July 10, 2021 15:14
@lgtm-com
Copy link

lgtm-com bot commented Jul 10, 2021

This pull request introduces 2 alerts and fixes 3 when merging 01983fa into 99ee21d - view on LGTM.com

new alerts:

  • 2 for Declaration hides variable

fixed alerts:

  • 3 for Unused static function

@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2021

This pull request introduces 2 alerts when merging 51ee091 into 99ee21d - view on LGTM.com

new alerts:

  • 2 for Declaration hides variable

psolstice
psolstice previously approved these changes Jul 11, 2021
@a-bezrukov a-bezrukov marked this pull request as ready for review July 12, 2021 06:49
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 5 alerts when merging 9551c06 into dc9620a - view on LGTM.com

new alerts:

  • 3 for Unused static function
  • 2 for Declaration hides variable

@a-bezrukov a-bezrukov merged commit 8192c5f into master Jul 12, 2021
@a-bezrukov a-bezrukov deleted the bip47_gui_fixes branch July 12, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants