Changed number of confirmations for spending a mint to 1 #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 2 alerts when merging d68f433 into d62dccf - view on LGTM.com fixed alerts:
|
| @@ -26,40 +26,6 @@ | |||
| ('100', False), ('100', False), | |||
| ] | |||
|
|
|||
| expected_pubcoins_after_denom_spend = { | |||
There was a problem hiding this comment.
I don't think it is better to remove hard-coded coin list, It will be hard to investigate in case of fail, or if we want to make this test just pass, let's remove it, as this functionality is not being used anymore.
levonpetrosyan93
approved these changes
Nov 18, 2021
|
This pull request fixes 4 alerts when merging 963e3d6 into 8665ae0 - view on LGTM.com fixed alerts:
|
levonpetrosyan93
pushed a commit
that referenced
this pull request
May 17, 2023
* Changed number of confirmations for spending a mint to 1 * Unit tests fix * Fixed python test * Removed obsolete test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Allow lelantus mints to be spent immediately after inclusion in block.
Code changes brief
Limitation on number of confirmations is UI only, no hardfork is introduced with this change.