Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for compilation with gcc 11 #1093

Merged
merged 9 commits into from
Dec 9, 2021
Merged

Fix for compilation with gcc 11 #1093

merged 9 commits into from
Dec 9, 2021

Conversation

psolstice
Copy link
Contributor

PR intention

Many compilation problems were fixed

Code changes brief

Masternode code dependencies were upgraded from latest dash code:

  • bls-signatures
  • relic
  • bls directory
    Dash code relying on these dependencies was patched

Depends packages upgraded/added in this PR:

  • qt (to bitcoin version)
  • boost (to 1.77, ahead of bitcoin at the time of this PR)
  • native_b2 (to bitcoin version)
  • libxkbcommon (to bitcoin version)

bls-signatures now builds without tests and make check doesn't run a test on it

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2021

This pull request introduces 46 alerts and fixes 63 when merging 0120d0e into f8fd1a8 - view on LGTM.com

new alerts:

  • 12 for No trivial switch statements
  • 8 for No raw arrays in interfaces
  • 7 for Declaration hides variable
  • 6 for Comparison result is always the same
  • 5 for Long switch case
  • 3 for Commented-out code
  • 3 for Unused static function
  • 1 for Unsigned comparison to zero
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 22 for Commented-out code
  • 14 for Unused static function
  • 12 for No raw arrays in interfaces
  • 2 for Catching by value
  • 2 for Long switch case
  • 2 for Array offset used before range check
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides variable
  • 1 for Missing header guard
  • 1 for Irregular enum initialization
  • 1 for Futile conditional
  • 1 for Sizeof with side effects
  • 1 for Comparison result is always the same
  • 1 for Empty branch of conditional
  • 1 for Suspicious pointer scaling to void

@AaronFeickert
Copy link
Contributor

Build succeeds on an Ubuntu 21.10 variant with --enable-tests flag. Required installation of the bison package for yacc support.

@AaronFeickert
Copy link
Contributor

Still able to build on an Ubuntu 21.10 variant.

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2021

This pull request introduces 43 alerts and fixes 63 when merging 6aca726 into f8fd1a8 - view on LGTM.com

new alerts:

  • 12 for No trivial switch statements
  • 8 for No raw arrays in interfaces
  • 7 for Declaration hides variable
  • 6 for Comparison result is always the same
  • 5 for Long switch case
  • 3 for Commented-out code
  • 1 for Unsigned comparison to zero
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 22 for Commented-out code
  • 14 for Unused static function
  • 12 for No raw arrays in interfaces
  • 2 for Catching by value
  • 2 for Long switch case
  • 2 for Array offset used before range check
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides variable
  • 1 for Missing header guard
  • 1 for Irregular enum initialization
  • 1 for Futile conditional
  • 1 for Sizeof with side effects
  • 1 for Comparison result is always the same
  • 1 for Empty branch of conditional
  • 1 for Suspicious pointer scaling to void

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2021

This pull request introduces 45 alerts and fixes 63 when merging d99fa9f into 7de8050 - view on LGTM.com

new alerts:

  • 12 for No trivial switch statements
  • 8 for No raw arrays in interfaces
  • 7 for Declaration hides variable
  • 6 for Comparison result is always the same
  • 5 for Long switch case
  • 3 for Commented-out code
  • 2 for Unused static function
  • 1 for Unsigned comparison to zero
  • 1 for Uncontrolled data used in path expression

fixed alerts:

  • 22 for Commented-out code
  • 14 for Unused static function
  • 12 for No raw arrays in interfaces
  • 2 for Catching by value
  • 2 for Long switch case
  • 2 for Array offset used before range check
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Declaration hides variable
  • 1 for Missing header guard
  • 1 for Irregular enum initialization
  • 1 for Futile conditional
  • 1 for Sizeof with side effects
  • 1 for Comparison result is always the same
  • 1 for Empty branch of conditional
  • 1 for Suspicious pointer scaling to void

@reubenyap reubenyap merged commit 6dfe159 into master Dec 9, 2021
@reubenyap reubenyap deleted the compilation-fix branch December 9, 2021 17:04
@reubenyap reubenyap added this to the v0.14.9.2 milestone Dec 15, 2021
levonpetrosyan93 pushed a commit that referenced this pull request May 17, 2023
* Updated bls library and its dependencies

* Fixed build of depends on newer gcc

* Removed tests for bls-signatures during "make check"

* Fixed Windows qt issues

* Fixed issue with mac

* Fix for building boost on older mingw toolchains

* Fixed compilation of dependencies on Mac

* Bumped Ubuntu version for Windows build on GA

* Fixed Windows dependencies compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants