Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validity check in GroupElement deserialization #1147

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

levonpetrosyan93
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 commented Feb 21, 2022

fix for #1122

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2022

This pull request introduces 2 alerts when merging 566da4f into d73a892 - view on LGTM.com

new alerts:

  • 2 for Unused static function

src/bip47/bip47utils.cpp Show resolved Hide resolved
src/secp256k1/src/cpp/GroupElement.cpp Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request introduces 2 alerts when merging bb58a10 into d73a892 - view on LGTM.com

new alerts:

  • 2 for Unused static function

@lgtm-com
Copy link

lgtm-com bot commented Feb 26, 2022

This pull request introduces 2 alerts when merging c35669f into d73a892 - view on LGTM.com

new alerts:

  • 2 for Unused static function

src/chainparams.cpp Show resolved Hide resolved
src/chainparams.cpp Show resolved Hide resolved
src/lelantus.cpp Show resolved Hide resolved
src/sigma/test/serialize_test.cpp Show resolved Hide resolved
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@reubenyap reubenyap merged commit 78e29d6 into master Mar 9, 2022
@reubenyap reubenyap deleted the groupelemet-deserialize branch March 9, 2022 00:51
levonpetrosyan93 added a commit that referenced this pull request May 17, 2023
* Added validity check in GroupElement deserialization

* Adding GroupElement validation test and removing unneeded test

* Allowing inifinity point in deserialization

* Catching trown exeptions, in case invalid group element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants