New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPC Wallet tests fix #567
RPC Wallet tests fix #567
Conversation
This pull request introduces 3 alerts when merging a32e423 into 53fb75c - view on LGTM.com new alerts:
|
@FreakyMaryk could you provide the example of wallet dump file? |
This pull request introduces 3 alerts when merging a873714 into 53fb75c - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request introduces 3 alerts when merging e23965b into 53fb75c - view on LGTM.com new alerts:
|
@riordant |
@thebevrishot Not a bug. When you generate a new wallet, it is in unencrypted state, and has a particular master seed. When you encrypt, it generates a new master seed. Both seeds generate 21 keys to be used for mints. The newer keys will always be used, that is, the keys for latest master seed will always be used for new mints. |
This pull request introduces 7 alerts when merging 7ccaccd into d159d4c - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 142e9dd into d159d4c - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR intention
RPC Wallet tests fix for:
Code changes brief
Time of tests executing was increased due to tests long-run (restarting/sync/dampwallet)
There are some TODO in this tests which are can be removed during review.