This repository has been archived by the owner on Jan 26, 2018. It is now read-only.
minimal hook #5
Merged
minimal hook #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # index.js
jgallen23
suggested changes
Feb 8, 2017
| scripts: process.cwd() | ||
| scripts: process.cwd(), | ||
| githubRoute: '/', | ||
| simpleRoute: '/simple', |
There was a problem hiding this comment.
doesn't look like you are checking this
lib/executeScripts.js
Outdated
|
|
||
| module.exports = (dataToProcess, options, callback) => { | ||
| async.autoInject({ | ||
| beforeHooks: done => runFirstExistingScript([ |
There was a problem hiding this comment.
this is really hard to read, can you put { } around?
lib/runFirstExistingScript.js
Outdated
| } | ||
| // todo: does this pass any params to the script? | ||
| runshell(existingScript, { | ||
| env: process.env, |
There was a problem hiding this comment.
we need to set REPO, BRANCH, USER on env. I believe new version of runshell already uses process.env
lib/simpleRoute.js
Outdated
|
|
||
| module.exports = (request, response, options) => { | ||
| SimpleSchema.validate(request.payload, (err, result) => { | ||
| if (err || result.length !== 4) { |
There was a problem hiding this comment.
this logic seems wrong... if err?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.