Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tweet text #1616

Closed
Roshanjossey opened this issue Nov 4, 2017 · 5 comments
Closed

Update tweet text #1616

Roshanjossey opened this issue Nov 4, 2017 · 5 comments

Comments

@Roshanjossey
Copy link
Member

🐞 Problem

Tweet shared currently has hacktoberfest hash tag. This is not needed anymore as hacktoberfest ended.

🎯 Goal

Have a better tweet text

💡 Possible solutions

You can find the code for tweet button in
https://github.com/Roshanjossey/first-contributions/blob/master/app/src/components/SocialShare/Twitter.jsx

In twitterLink, remove hacktoberfest hashtag and put something more appropriate

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@mandyreal
Copy link

mandyreal commented Nov 5, 2017

hi @Roshanjossey submitted a pr to remove the #hacktoberfest. thanks.

Roshanjossey added a commit that referenced this issue Nov 5, 2017
@Roshanjossey
Copy link
Member Author

@mandyreal, I just merged the pr. Would you like to put a different tag in place of hacktoberfest?

@mandyreal
Copy link

#CodeNewbie perhaps? any more suggestions? let me know. thanks.

@Roshanjossey
Copy link
Member Author

@mandyreal, #CodeNewbie sounds good. I just did a search and saw a lot of tweets in this hashtag. Seems relevant. Would you like to make this change?

@mandyreal
Copy link

@Roshanjossey sure, will do! thanks for the feedback. will submit PR in a bit.

Roshanjossey added a commit that referenced this issue Nov 5, 2017
Addresses #1616 - added #CodeNewbie in the tweet text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants