Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__fish_complete_command doesn't correctly handle prefixed usage #10011

Closed
ModProg opened this issue Sep 10, 2023 · 0 comments
Closed

__fish_complete_command doesn't correctly handle prefixed usage #10011

ModProg opened this issue Sep 10, 2023 · 0 comments
Labels
bug Something that's not working as intended completions
Milestone
fish 3.7.0

Comments

@ModProg
Copy link
Contributor

ModProg commented Sep 10, 2023

This conflicts with its usage in, e.g., complete as this is hardly the correct completion:

complete --command=--command=
…-command=0                                                                          (command)
…-command=1                                                                          (command)
…-command=2                                                                          (command)
…-command=2to3                                                                  (command link)
…-command=2to3-2.7                                                                   (command)
…-command=2to3-3.11                                                                  (command)
…-command=4channels                                                                  (command)
…-command=7                                                                          (command)
…-command=7z                                                                         (command)
…-command=7za                                                                        (command)
@faho faho closed this as completed in b03327f Sep 10, 2023
@faho faho added bug Something that's not working as intended completions labels Sep 10, 2023
@faho faho added this to the fish 3.7.0 milestone Sep 10, 2023
faho added a commit that referenced this issue Oct 8, 2023
@faho
__fish_complete_command: Fix --foo= logic
57bd21e 
This was already supposed to handle `--foo=bar<TAB>` cases, except it
printed the `--foo=` again, causing fish to take that as part of the
token.

See #9538 for a similar thing with __fish_complete_directories.

Fixes #10011

(cherry picked from commit b03327f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that's not working as intended completions
Projects
None yet
Milestone
fish 3.7.0
Development

No branches or pull requests
2 participants
@faho @ModProg