'commandline -f' interprets functions in reverse

[favdish]

This doesn't work correctly, since it only performs the execute call:
bind \em 'commandline -f accept-autosuggestion; commandline -f execute'
Reversing the order of the calls does work:
bind \em 'commandline -f execute; commandline -f accept-autosuggestion'
bind \em 'commandline -f execute accept-autosuggestion'
Strange... is that a bug or a feature?

[ridiculousfish]

commandline -f invokes input_unreadch, which pushes commands onto a stack. Stacks are LIFO, so that explains this observation.

I think this dates back to fish 1.x. I would call it a bug - commands ought to be a queue, not a stack.

[favdish]

Well, once it's clear that the functions are called in a stack-like fashion it's NBD. A hint in the docs would've been great... would have saved me some swearing:-)

[ridiculousfish]

I want to try to fix this before the compatibility concerns mean we can't.

[terlar]

It also seems like you cannot execute any other operation after commandline -f execute. If you would run the following:

function __execute_and_keep_line
  set -l pos (commandline -C)
  set -l cmd (commandline -b)

  commandline -f execute
  commandline -r "$cmd"
  commandline -C $pos
end
bind \e\n __execute_and_keep_line

No matter which order you run it, it always stops at execute and don't run other stuff after.