Multi condition if statements can produce some very wierd behaviour

[taksuyu]

function check_path
    if test -d $argv[1]
        echo "$argv[1] made it through test"
        if not contains $argv[1] $PATH
            echo "$argv[1] will be added"
            set PATH $argv[1] $PATH
        end
    end
end

Works, but

function check_path
    if test -d $argv[1]; and not contains $argv[1] $PATH
            set PATH $argv[1] $PATH
    end
end

Doesn't

[ridiculousfish]

Your expectation for how and behaves is very reasonable, but it's not so. The loop condition is a single command, and so the and does not attach to it, i.e. it's parsed as:

if test -d $argv[1]
    and not contains $argv[1] $PATH
    set PATH $argv[1] $PATH
end

To get the behavior you want, you have to group them with begin/end:

 if begin; test -d $argv[1]; and not contains $argv[1] $PATH; end
     set PATH $argv[1] $PATH
 end

which is definitely awkward.

it might be worth producing a warning in the case when 'and' follow an if statement immediately, or possibly just fixing it so it works like you would want, or supporting && (see #150).

[taksuyu]

I actually tried it with a test statement too, which produced strange results

if test -d $argv[1] -a ! contains $argv[1] $PATH

if test -d $argv[1] -a (not contains $argv[1] $PATH)

but yeah, I agree with you.

I'd actually like to see && and || specifically for if, but I imagine that a lot of people make the mistake I do with and.

[faho]

See also #1428.

[faho]

This should be fixed like #1428.