Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish doesn't complete custom git commands #1680

Closed
xdudi opened this issue Sep 14, 2014 · 3 comments
Closed

fish doesn't complete custom git commands #1680

xdudi opened this issue Sep 14, 2014 · 3 comments
Assignees
Milestone

Comments

@xdudi
Copy link

xdudi commented Sep 14, 2014

Fish should seach executable files like: git-command and complete its by tab.
For example, i have: /usr/local/bin/git-history
When i type: git histo<TAB>, it should complete it.

Bash makes it correctly.

@zanchey
Copy link
Member

zanchey commented Sep 15, 2014

Bash does this by scraping the output of git help:

git help -a|egrep '^  [a-zA-Z0-9]'

@zanchey zanchey added this to the fish-future milestone Sep 15, 2014
@lilyball
Copy link
Contributor

Looks like that picks up all git commands, not just custom commands. Custom commands "git foo" can be completed by completing the name "git-foo" instead, which is all git does to find them anyway.

@lilyball
Copy link
Contributor

The benefit of bash's approach is it will pick up new builtin git commands as well, though the downside is it will expose them by default, whereas the current git bash completion actually blacklists a lot of commands (e.g. plumbing commands).

@lilyball lilyball self-assigned this Sep 20, 2014
@lilyball lilyball modified the milestones: next-minor, fish-future Sep 20, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants