Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function function_add called with null value for argument ! data.name.empty(). #2519

Closed
ghost opened this issue Nov 3, 2015 · 2 comments
Closed
Assignees
Labels
bug Something that's not working as intended
Milestone

Comments

@ghost
Copy link

ghost commented Nov 3, 2015

The following should report an error, not a stack trace.

function -e foo
end
fish: function function_add called with null value for argument ! data.name.empty().
fish: This is a bug. Break on bugreport to debug.If you can reproduce it, please send a bug report to fish-users@lists.sf.net.
fish: Backtrace:
0   fish                                0x00000001094eca60 _Z15show_stackframev + 112
1   fish                                0x0000000109483ab6 _Z15define_functionR8parser_tR12io_streams_tRKNSt3__16vectorINS3_12basic_stringIwNS3_11char_traitsIwEENS3_9allocatorIwEEEENS8_ISA_EEEERKSA_iPSA_ + 5366
2   fish                                0x000000010950c3c5 _ZN25parse_execution_context_t22run_function_statementERK12parse_node_tS2_ + 501
3   fish                                0x000000010950bb94 _ZN25parse_execution_context_t9run_1_jobERK12parse_node_tPK7block_t + 532
4   fish                                0x000000010950c0a9 _ZN25parse_execution_context_t12run_job_listERK12parse_node_tPK7block_t + 137
5   fish                                0x000000010950f2de _ZN25parse_execution_context_t19eval_node_at_offsetEjPK7block_tRK10io_chain_t + 350
6   fish                                0x00000001094be72c _ZN8parser_t15eval_block_nodeEjRK10io_chain_t12block_type_t + 332
7   fish                                0x00000001094bde55 _ZN8parser_t4evalERKNSt3__112basic_stringIwNS0_11char_traitsIwEENS0_9allocatorIwEEEERK10io_chain_t12block_type_t + 501
8   fish                                0x00000001094c580e _Z18reader_run_commandR8parser_tRKNSt3__112basic_stringIwNS1_11char_traitsIwEENS1_9allocatorIwEEEE + 270
9   fish                                0x00000001094cc5e8 _Z11reader_readiRK10io_chain_t + 952
10  fish                                0x000000010951736a main + 4986
11  libdyld.dylib                       0x00007fff86d855ad start + 1
function: Expected function name
@ridiculousfish
Copy link
Member

Nice find 👍

@ridiculousfish ridiculousfish self-assigned this Nov 3, 2015
@faho faho added the bug Something that's not working as intended label Nov 4, 2015
@zanchey zanchey added this to the next-2.x milestone Nov 26, 2015
@ridiculousfish
Copy link
Member

Thanks for reporting this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

3 participants