Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish doesn't build on RHEL 5 #2955

Closed
zanchey opened this issue Apr 19, 2016 · 1 comment
Closed

fish doesn't build on RHEL 5 #2955

zanchey opened this issue Apr 19, 2016 · 1 comment
Assignees
Labels
bug Something that's not working as intended
Milestone

Comments

@zanchey
Copy link
Member

zanchey commented Apr 19, 2016

Apparently I don't get emails when builds fail any more!

For some time now, the build has been failing on RHEL 5, as O_CLOEXEC is not available:

[   80s] g++ -O2 -g -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables -D_LARGEFILE_SOURCE=1 -D_FILE_OFFSET_BITS=64 -fno-exceptions -Wall -Wno-sign-compare -D_GNU_SOURCE=1 -D_ISO99_SOURCE=1  -Ipcre2-10.21/src -iquote. -iquote./src/ -DLOCALEDIR=\"/usr/share/locale\" -DPREFIX=L\"/usr\" -DDATADIR=L\"/usr/share\" -DSYSCONFDIR=L\"/etc\" -DBINDIR=L\"/usr/bin\" -DDOCDIR=L\"/usr/share/doc/fish\"  -DFISH_BUILD_VERSION=\"2.2.0-787-g9aeed0d\" -c src/input_common.cpp -o obj/input_common.o
[   81s] src/env_universal_common.cpp: In member function 'bool env_universal_t::open_temporary_file(const wcstring&, wcstring*, int*)':
[   81s] src/env_universal_common.cpp:690: error: 'O_CLOEXEC' was not declared in this scope

RHEL5 isn't that old, so it would be good to continue supporting it.

@zanchey zanchey added this to the 2.3.0 milestone Apr 19, 2016
@zanchey zanchey self-assigned this Apr 27, 2016
@zanchey
Copy link
Member Author

zanchey commented Apr 27, 2016

The problem here is that O_CLOEXEC is entirely the wrong flag to be passing - it should be FD_CLOEXEC!

@krader1961 krader1961 added the bug Something that's not working as intended label Mar 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants