make kill/pkill completions more robust #3200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone running fish in an unusual locale reported that an `assert()` was firing when they typed `pkill c`. I traced it to two bugs. First, the __fish_make_completion_signals command was producing a weird result. Second, the builtin `complete` command wasn't adequately verifying its arguments. Fixes #3129
|
@mikroskeem: Can you put the the __fish_make_completion_signals.fish from this PR in your ~/.config/fish/functions directory, start a fresh fish shell, and verify the problem no longer occurs? |
|
No feedback so I'm going to assume no one has any objections to this fix and merge it. |
|
Yes, this looks fine :-) |
krader1961
added a commit
that referenced
this pull request
Jul 8, 2016
Someone running fish in an unusual locale reported that an `assert()` was firing when they typed `pkill c`. I traced it to two bugs. First, the __fish_make_completion_signals command was producing a weird result. Second, the builtin `complete` command wasn't adequately verifying its arguments. Fixes #3129
|
@krader1961 Sorry, I'm bit late to this party. But this PR fixes my problem. I can now use my own locale freely with fish, thanks :) 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone running fish in an unusual locale reported that an
assert()wasfiring when they typed
pkill c. I traced it to two bugs. First, the__fish_make_completion_signals command was producing a weird result. Second,
the builtin
completecommand wasn't adequately verifying its arguments.Fixes #3129
I've tested this on Ubuntu and OS X using the C, en_US.UTF-8, and et_EE.UTF-8 locales. On OS X I have GNU coreutils setup as my standard commands thus replacing the standard OS X
killcommand.