Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_color should support equivalent of tput smso (set standout mode) #3249

Closed
krader1961 opened this issue Jul 17, 2016 · 2 comments
Closed

Comments

@krader1961
Copy link
Contributor

The solution for issue #2904 ultimately involved setting and clearing the terminal standout mode with tput smso and tput rmso. It would be nice if we didn't have to shell out to an external command to do something so useful. Whether it's done via pseudo colors (e.g. set_color standout) or adding new flags is TBD.

@krader1961 krader1961 added this to the fish-future milestone Jul 17, 2016
@floam
Copy link
Member

floam commented Jul 25, 2016

I think that should be a flag as the colors will be modified by it/will persist through it, albeit inverted. Same with tput rev. The set_color interface kind of stinks but I think this is not like "normal" or "reset" in that regard.

--standout makes sense to me. I wouldn't try to think up a cute analogous name for something that is rather this rather specific mode.

@floam floam modified the milestones: next-2.x, fish-future Aug 3, 2016
@zanchey zanchey modified the milestones: fish-future, fish 2.5.0 Dec 3, 2016
@krader1961
Copy link
Contributor Author

This was implemented by commit b22842a on 2016-12-31 (PR #3650).

@zanchey zanchey modified the milestones: fish 2.5.0, fish-future Feb 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants