Colour of partial matched suggestion in light terminal theme is un-readable

[feigaoxyz]

• Have you checked if problem occurs with fish 2.3.1?
• Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version):
fish, version 2.3.1-541-gf9115b5

OS/terminal used:
iTerm

The colour for partial match in completion suggestion is whitish and I found no way to customise it. This is fine for dark themes in terminal. But if I use light themes in my terminal (e.g. iTerm), such as "Light Background" or "Solarized Light", the characters become un-readable. Check attached screenshots.

Dark Theme:

Light Theme:

Any workaround for improving the readability in light themes?

[floam]

Hm, it looks like this here:

[faho]

@feigaoxyz: You'll want to change $fish_color_autosuggestion. Also consider picking a colorscheme via fish_config.

[floam]

There were some changes made to how colors work rather recently - if by chance it looks like that for you wth an official color scheme or defaults from an older version of fish - let me know and we can address trying to automatically reset the necessary variable for 2.4.0.

[floam]

Are you sure that's fish_color_autosuggestion @faho? The problem is the prefixed match parts.

[floam]

"br" in "brctl", etc.

[faho]

Are you sure that's fish_color_autosuggestion @faho? The problem is the prefixed match parts.

Sorry, $fish_pager_color_prefix. I'd blame my color-blindness but there's no red or green involved (I think), so it's just me being a dumbo.

[feigaoxyz]

Thanks, @faho, $fish_pager_color_prefix is the answer for me.

@floam
The screenshots are taken under new fish profile (by sh -c 'env HOME=$(mktemp -d) fish'), so I guess it is the official color scheme.
And I used iTerm with default "Dark Background" and "Light Background" color presets, respectively.

[DivineGod]

I switched to a light theme and encountered this issue as well, some digging suggest that the way the fish_pager_color_prefix is configured at default is with a white --bold --underline which is used in highlight.cpp

More intuitively would be if any color definitions would use the thematic definitions of colors and those colors should in turn probably rely on (set_color ...) in any fish config

[mrjohannchang]

fish-shell/share/functions/__fish_config_interactive.fish

Line 35 in 49e98cd

#

By running this file, the suggestion color will be very light so it's hard to read in light background.
The default color scheme has been changed since 90e535f

[morberg]

I don't think changing the color theme in fish sets any fish_pager_color_* variables, only fish_color_* seems to be affected?

[faho]

I don't think changing the color theme in fish sets any fish_pager_color_* variables, only fish_color_* seems to be affected?

Yes, that's true. No theme currently includes pager colors. In general the fish_config colorscheme stuff could use some love (ideally the color schemes would also be available without going via js, to make an in-terminal colorscheme-picker). Patches very much welcome!