completion ignoring . prefixed arguments

[nhooyr]

• Have you checked if problem occurs with fish 2.4.0?
• Tried fish without third-party customizations (check sh -c 'env HOME=$(mktemp -d) fish')?

fish version installed (fish --version): 2.4.0

OS/terminal used: macOS 10.12.2 iTerm 3.0.13

completion ignores arguments that start with .. I think this is to ignore dotfiles but I have a command that can be completed with a file that starts with . and it should not be ignored. Is it possible to disable this?

watch https://asciinema.org/a/9wnu3jy22hxfjf4au18m7ob29

[ridiculousfish]

This is by design. The default file completion will only show hidden files if your argument starts with a . After all, hidden files should be hidden.

We wouldn't introduce a config option for this.

I thought it should be possible to write a custom completion, but it looks like fish squashes custom completions that start with . unless the token starts with . (I thought this only happened for file completions, but it looks like it happens all the time). That's probably a bug, and one that can be fixed.

For now though I think this just isn't possible, sorry!

[nhooyr]

I'm asking about custom completion not for file completion.

[krader1961]

@nhooyr: Please update this issue with your custom completion script that is not working as you desire. I cannot tell from your asciinema recording what complete commands were in effect that you expected to behave differently. Also, your asciinema recording is ambiguous since it has insufficient context, in conjunction with this issue, to understand what is not working as you expected.

It should be possible to inhibit the usual file name completion for strings beginning with .. But that is clearly an enhancement and we need more details about your use case.

[nhooyr]

Sorry, I didn't realize I was so unclear when I wrote this.

Here is the script https://github.com/nhooyr/dotfiles/blob/812056d8e13d99dd6bb3eced79b8d13dbb8e91d5/.config/fish/completions/bd.fish

Fish doesn't show me .config .foo .bar if I don't have a period in front when I attempt to complete. It only shows me foo 99j bar.

[krader1961]

Hmmm, okay, you're adding an explicit completion that includes arguments that begin with a period:

complete -c bd -f -a '.config foo 99j .foo .bar bar'

And those do not show up in the completion list. I'm inclined to agree that explicitly enumerating arguments that begin with a period should be displayed and selectable after pressing [tab] even if you haven't typed a period. Whereas the behavior for file name expansion should continue to exclude such file names unless you have started the argument with a period before pressing [tab].

[ridiculousfish]

Yes, me too - the hidden file behavior is only supposed to apply to files, not bespoke completions.

[rmartine-ias]

I would like this too

This would be a useful enhancement to me -- my company has a practice of having CI code in a .ci/ directory, and I frequently make changes to it. git add does not tab complete the files in that directory. It looks like it should:

complete -f -c git -n '__fish_git_using_command add' -a '(__fish_git_files modified untracked deleted unmerged modified-staged-deleted)'

(__fish_git_files correctly returns the dot-prefixed paths. I think it would make sense, like you said, for explicitly added completions to work, even if they start with a dot.)

Each time I do a tab completion for this, I get confused for a second, go "oh right", and add a dot and press tab again. It's a minor annoyance, but one I deal with very frequently.

---

Temp. solution for git add specifically

Now that I've figured out it's fish's fault, and not a misconfigured git, I can do something about it. For anyone else with this same exact git add issue, here's a solution (excuse my poor fish):

function confirm -a 'prompt' -d "Confirm whether or not to do something"
    if test -z "$prompt"
        set prompt 'Are you sure?'
    end

    read -f -p "set_color green; echo \"$prompt [y/N]\"; set_color normal" response
    switch "$response"
        case y Y
            true
        case '*'
            false
    end
end

function gap -d "Git add one file, or prompt for all"
    if [ (git status --porcelain | wc -l) = 1 ]
        git add -v -A # -v prints the added file
    else
        # can we prompt one by one, but better than git add --interactive?
       git status; confirm "Add all?"; and git add -A
    end
end

Replacing ga <tab><return> with gap<return> is.. better. Remember as "git add, please".

[ridiculousfish]

Fixed in b7de768. Thank you for filing.