Brace expansion getting in the way in git stash apply

[jamesgecko]

The following git command breaks when I use it in fish.

In fish:

 [1] ><((ˣ> g stash apply stash@{3}
 fatal: ambiguous argument 'stash@3': unknown revision or path not in the working tree.
 Use '--' to separate paths from revisions

In bash:

 bash-3.2$ git stash apply stash@{3}
 # On branch working
 # Changes not staged for commit:
 #   (use "git add <file>..." to update what will be committed)
 #   (use "git checkout -- <file>..." to discard changes in working directory)
 #
 #  modified:   spec/data/stuff.dat
 #
 # Untracked files:
 #   (use "git add <file>..." to include in what will be committed)
 #
 #  routes
 no changes added to commit (use "git add" and/or "git commit -a")

[ridiculousfish]

{ and } are special characters in fish.

[j0hnsmith]

You have to use quotes git stash apply 'stash@{3}'

[ghost]

Even bash has strange behaviour:

$ echo H{a}
 H{a}
$ echo H{a,b}
Ha Hb
$ echo $BASH_VERSION 
4.2.37(1)-release

[franciscolourenco]

This is a considerable inconvenience..

[KamilaBorowska]

Perhaps it would be a good idea to use more recognizable color for symbols like { and } by default. Currently, they have very similar color to standard letters, making this even more confusing (even if those colors aren't exactly identical).

[zanchey]

That sounds like it would be worth a go @xfix

[KamilaBorowska]

It's hard to think of any particular color, but it seems that #ff87d7 works well. The alternative is green (which is often used in text editors to mark variables), but that could be confusing with the default prompt being green. I made two screenshots for comparison reasons. I don't think that any particular sets other than black on white, and white on black have to be considered here. If someone uses pink background, or something, it's possible to fix such issues with fish_config anyway.

Please note that variables aren't highlighted on those screenshots. The proposal to improve this is available to read at #1201.

[smarzougui]

Hello,

You can do this for example:
git stash apply stash@{2}

You have to escape the "{".

[faho]

We now have tab completion that offers the properly escaped versions, so it should be easy to pick one and it should be clear that escaping is necessary. I believe this issue is fixed.