eval scope

[mqudsi]

Is the following a bug or a feature?

eval set -l foo bar
if not echo "bar" | string match -q $foo
    echo Assertion failed!
end

eval isn't explicitly documented as creating a scope.

(note that this "feature" caused some consternation in the implementing of #4442)

[mqudsi]

See #565 (comment)

Still not clear on whether it's a bug or not, though.

[mqudsi]

@ridiculousfish any thoughts on this?

[ridiculousfish]

It's a bug due to eval's implementation as a function. I thought we had another issue tracking this.

[mqudsi]

This should work correctly now.

[faho]

Okay, so the eval builtin doesn't create a new scope, but source still does?

I think we might want to change it in source as well?

[mqudsi]

I keep remembering I need to reply to this and then forgetting to do so.

TBH, I like that source has its own scope -- since you're typically editing the files out-of-band and they're expected to play nice regardless of how they're loaded, etc. I feel it would be counter-intuitive for source to use the existing scope. I'd prefer just officially changing that from "bug" to "feature" and explicitly documenting that source creates a new scope.

[zanchey]

Noted in the docs.

[mqudsi]

Thanks, @zanchey!