-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
running some interactive program via keybinding doesn't work as expected #4772
Comments
Off the top of my head: it's possible bash doesn't steal the terminal for itself and relies on the parent to assign it and fish is executing the bind actions in the background? |
The underlying issue here is that we don't reset the terminal modes when we execute a command via a binding. zsh seems to reset them, while bash doesn't. However, it does generally work, it just won't show characters echo'd. Maybe we should reset the terminal modes in this case? The workaround is to add |
Background: I'm trying to implement some shortcut key to pick an remote machine with
fzf
andssh
into picked machine, when I run my function by typing its name, it works well, but it failed with keybindingThe text was updated successfully, but these errors were encountered: