add makensis #5242
Merged
add makensis #5242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faho
reviewed
Oct 9, 2018
| # System to create Windows installers | ||
| # See: https://nsis.sourceforce.io | ||
|
|
||
| complete -c makensis -o CMDHELP -d 'Prints out help for a specific command, or lists all commands' |
There was a problem hiding this comment.
So this is used as makensis -CMDHELP, with one "-"?
faho
reviewed
Oct 9, 2018
makensis.fish
Outdated
| complete -c makensis -o V2 -d 'Verbosity: no info' | ||
| complete -c makensis -o V3 -d 'Verbosity: no script' | ||
| complete -c makensis -o V4 -d 'Verbosity: all' | ||
| complete -c makensis -o V4 -d 'Verbosity: all' |
faho
reviewed
Oct 9, 2018
| complete -c makensis -o P2 -d 'Sets the compiler process priority to normal' | ||
| complete -c makensis -o P3 -d 'Sets the compiler process priority to above normal' | ||
| complete -c makensis -o P4 -d 'Sets the compiler process priority to high' | ||
| complete -c makensis -o P5 -d 'Sets the compiler process priority to realtime' |
There was a problem hiding this comment.
Below you have "Verbosity: all", why not say "compiler process priority: realtime" here?
makensis.fish
Outdated
| @@ -0,0 +1,26 @@ | |||
| # System to create Windows installers | |||
| # See: https://nsis.sourceforce.io | |||
There was a problem hiding this comment.
This link seems broken to me?
|
Merged, thanks! |
|
Am I missing something? Why is |
mqudsi
added a commit
that referenced
this pull request
Oct 16, 2018
|
@mqudsi: Terribly sorry, I did not expect that! |
|
No harm done :) |
ridiculousfish
pushed a commit
to ridiculousfish/fish-shell
that referenced
this pull request
Nov 24, 2018
* add makensis * remove duplicate line * fix typo
ridiculousfish
pushed a commit
to ridiculousfish/fish-shell
that referenced
this pull request
Nov 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Talk about your changes here.
Fixes issue #
TODOs: