New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add makensis #5242

Merged
merged 3 commits into from Oct 14, 2018

Conversation

Projects
None yet
4 participants
@idleberg
Copy link
Contributor

idleberg commented Oct 9, 2018

Description

Talk about your changes here.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
# System to create Windows installers
# See: https://nsis.sourceforce.io

complete -c makensis -o CMDHELP -d 'Prints out help for a specific command, or lists all commands'

This comment has been minimized.

@faho

faho Oct 9, 2018

Member

So this is used as makensis -CMDHELP, with one "-"?

complete -c makensis -o V2 -d 'Verbosity: no info'
complete -c makensis -o V3 -d 'Verbosity: no script'
complete -c makensis -o V4 -d 'Verbosity: all'
complete -c makensis -o V4 -d 'Verbosity: all'

This comment has been minimized.

@faho

faho Oct 9, 2018

Member

This line is duplicated.

complete -c makensis -o P2 -d 'Sets the compiler process priority to normal'
complete -c makensis -o P3 -d 'Sets the compiler process priority to above normal'
complete -c makensis -o P4 -d 'Sets the compiler process priority to high'
complete -c makensis -o P5 -d 'Sets the compiler process priority to realtime'

This comment has been minimized.

@faho

faho Oct 9, 2018

Member

Below you have "Verbosity: all", why not say "compiler process priority: realtime" here?

@faho faho added this to the fish-3.0 milestone Oct 9, 2018

@@ -0,0 +1,26 @@
# System to create Windows installers
# See: https://nsis.sourceforce.io

This comment has been minimized.

@ridiculousfish

ridiculousfish Oct 9, 2018

Member

This link seems broken to me?

@faho faho merged commit 36d3714 into fish-shell:master Oct 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@faho

This comment has been minimized.

Copy link
Member

faho commented Oct 14, 2018

Merged, thanks!

@mqudsi

This comment has been minimized.

Copy link
Contributor

mqudsi commented Oct 16, 2018

Am I missing something? Why is makensis.fish in the root?

mqudsi added a commit that referenced this pull request Oct 16, 2018

@faho

This comment has been minimized.

Copy link
Member

faho commented Oct 16, 2018

@mqudsi: Terribly sorry, I did not expect that!

@mqudsi

This comment has been minimized.

Copy link
Contributor

mqudsi commented Oct 17, 2018

No harm done :)

ridiculousfish added a commit to ridiculousfish/fish-shell that referenced this pull request Nov 24, 2018

add makensis (fish-shell#5242)
* add makensis

* remove duplicate line

* fix typo

ridiculousfish added a commit to ridiculousfish/fish-shell that referenced this pull request Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment