Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add makensis #5242

Merged
merged 3 commits into from Oct 14, 2018
Merged

add makensis #5242

merged 3 commits into from Oct 14, 2018

Conversation

@idleberg
Copy link
Contributor

@idleberg idleberg commented Oct 9, 2018

Description

Talk about your changes here.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md
# System to create Windows installers
# See: https://nsis.sourceforce.io

complete -c makensis -o CMDHELP -d 'Prints out help for a specific command, or lists all commands'
Copy link
Member

@faho faho Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is used as makensis -CMDHELP, with one "-"?

Loading

makensis.fish Outdated
complete -c makensis -o V2 -d 'Verbosity: no info'
complete -c makensis -o V3 -d 'Verbosity: no script'
complete -c makensis -o V4 -d 'Verbosity: all'
complete -c makensis -o V4 -d 'Verbosity: all'
Copy link
Member

@faho faho Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is duplicated.

Loading

complete -c makensis -o P2 -d 'Sets the compiler process priority to normal'
complete -c makensis -o P3 -d 'Sets the compiler process priority to above normal'
complete -c makensis -o P4 -d 'Sets the compiler process priority to high'
complete -c makensis -o P5 -d 'Sets the compiler process priority to realtime'
Copy link
Member

@faho faho Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Below you have "Verbosity: all", why not say "compiler process priority: realtime" here?

Loading

@faho faho added this to the fish-3.0 milestone Oct 9, 2018
makensis.fish Outdated
@@ -0,0 +1,26 @@
# System to create Windows installers
# See: https://nsis.sourceforce.io
Copy link
Member

@ridiculousfish ridiculousfish Oct 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link seems broken to me?

Loading

@faho faho merged commit 36d3714 into fish-shell:master Oct 14, 2018
1 check passed
Loading
@faho
Copy link
Member

@faho faho commented Oct 14, 2018

Merged, thanks!

Loading

@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Oct 16, 2018

Am I missing something? Why is makensis.fish in the root?

Loading

mqudsi added a commit that referenced this issue Oct 16, 2018
@faho
Copy link
Member

@faho faho commented Oct 16, 2018

@mqudsi: Terribly sorry, I did not expect that!

Loading

@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Oct 17, 2018

No harm done :)

Loading

ridiculousfish added a commit to ridiculousfish/fish-shell that referenced this issue Nov 24, 2018
* add makensis

* remove duplicate line

* fix typo
ridiculousfish added a commit to ridiculousfish/fish-shell that referenced this issue Nov 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants