Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_title has extra spaces #5517

Closed
jadenPete opened this issue Jan 12, 2019 · 2 comments
Closed

fish_title has extra spaces #5517

jadenPete opened this issue Jan 12, 2019 · 2 comments
Labels
Milestone

Comments

@jadenPete
Copy link

@jadenPete jadenPete commented Jan 12, 2019

This is a very simple bug, so I'm not going to provide unnecessary information. The fish_title function displays extra spaces, and it should be changed from:

function fish_title
    echo (status current-command) " " (__fish_pwd)
end

to:

function fish_title
    echo -s (status current-command) " " (__fish_pwd)
end
@mqudsi mqudsi closed this in 2fdcc45 Jan 13, 2019
@zanchey
Copy link
Member

@zanchey zanchey commented Jan 14, 2019

This goes all the way back to 2005! I'm wondering if it was intentional, although I think it's fine to remove.

@zanchey zanchey added the bug label Jan 14, 2019
@zanchey zanchey modified the milestones: fish 3.1.0, fish 3.0.1 Jan 14, 2019
@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Jan 22, 2019

This is in 3.0.1 as d5d80c0

ridiculousfish added a commit that referenced this issue Jan 22, 2019
Closes #5517. Credit goes to @jadenPete.

[skip-ci]
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants