Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompletion for git contains paths double #5574

Closed
danrot opened this Issue Jan 23, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@danrot
Copy link

danrot commented Jan 23, 2019

I've updated fish to version 3.0.0 on Archlinux. Now git add does not work as excpected (at least for me) anymore:

daniel@macbook ~/D/s/s/v/s/sulu $ git add 
:/src/Sulu/Bundle/AdminBundle/Resources/js/components/Card  (Untracked file)
src/Sulu/Bundle/AdminBundle/Resources/js/components/Card/  (Untracked file)

I'd like to not have the versions with the colon as options, because it clutters the autocompletion, and feels quite messy to me (especially when I am using a smaller terminal, and the lines have to break).

Apart from that you can see in the screenshot that the files in this folder are not suggested anymore when the entire folder was newly created, which is also very annyoing.

Is there anyway to configure this behavior, or do I have to live with it?

@faho faho closed this in 4af2a68 Jan 23, 2019

@faho faho added this to the fish 3.0.1 milestone Jan 23, 2019

faho added a commit to faho/fish-shell that referenced this issue Jan 23, 2019

completions/git: Stop offering :/ files so much
Don't do it when the relative path is simple (purely descending),
unless the token starts with ":/".

Also stop offering directories - if they need to be disambiguated, the
normal completion logic will take care of that.

Fixes fish-shell#5574.

[ci skip]
@danrot

This comment has been minimized.

Copy link
Author

danrot commented Jan 23, 2019

That was fast 🙈 Thank you! Looking forward to this release 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.