Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocompletion for git contains paths double #5574

Closed
danrot opened this issue Jan 23, 2019 · 1 comment
Closed

Autocompletion for git contains paths double #5574

danrot opened this issue Jan 23, 2019 · 1 comment
Labels
completions enhancement
Milestone
fish 3.0.1

Comments

@danrot
Copy link

danrot commented Jan 23, 2019 •
edited
Loading

I've updated fish to version 3.0.0 on Archlinux. Now git add does not work as excpected (at least for me) anymore:

daniel@macbook ~/D/s/s/v/s/sulu $ git add 
:/src/Sulu/Bundle/AdminBundle/Resources/js/components/Card  (Untracked file)
src/Sulu/Bundle/AdminBundle/Resources/js/components/Card/  (Untracked file)

I'd like to not have the versions with the colon as options, because it clutters the autocompletion, and feels quite messy to me (especially when I am using a smaller terminal, and the lines have to break).

Apart from that you can see in the screenshot that the files in this folder are not suggested anymore when the entire folder was newly created, which is also very annyoing.

Is there anyway to configure this behavior, or do I have to live with it?
@faho faho closed this as completed in 4af2a68 Jan 23, 2019
@faho faho added this to the fish 3.0.1 milestone Jan 23, 2019
faho added a commit to faho/fish-shell that referenced this issue Jan 23, 2019
@faho
completions/git: Stop offering :/ files so much
c20187e 
Don't do it when the relative path is simple (purely descending),
unless the token starts with ":/".

Also stop offering directories - if they need to be disambiguated, the
normal completion logic will take care of that.

Fixes fish-shell#5574.

[ci skip]
@danrot
Copy link
Author

danrot commented Jan 23, 2019

That was fast 🙈 Thank you! Looking forward to this release 🙂

@ElijahLynn ElijahLynn mentioned this issue Feb 13, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
completions enhancement
Projects
None yet
Milestone
fish 3.0.1
Development

No branches or pull requests
2 participants
@danrot @faho