Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command $foo broken highlighting #5658

Closed
mqudsi opened this issue Feb 14, 2019 · 4 comments
Closed

command $foo broken highlighting #5658

mqudsi opened this issue Feb 14, 2019 · 4 comments
Assignees
Labels
bug
Milestone

Comments

@mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Feb 14, 2019

fish 3.0 added support to use command $foo to execute the command whose name/path is stored in $foo, but the syntax highlighting code was not updated to take into account that a variable is now can be a valid execution target, and as a result $foo is always highlighted in red (since there is no executable literally named $foo).

e.g.

image

@floam
Copy link
Member

@floam floam commented Feb 14, 2019

Same thing with builtin $foo after 038fea1.

@floam floam added the bug label Feb 14, 2019
@zanchey zanchey added this to the fish-future milestone Feb 14, 2019
@ridiculousfish ridiculousfish self-assigned this Feb 18, 2019
@ridiculousfish ridiculousfish removed this from the fish-future milestone Feb 18, 2019
@ridiculousfish ridiculousfish added this to the fish 3.1.0 milestone Feb 18, 2019
@mqudsi
Copy link
Contributor Author

@mqudsi mqudsi commented Apr 12, 2019

and plain, old $foo:

image

@ridiculousfish
Copy link
Member

@ridiculousfish ridiculousfish commented Apr 13, 2019

Yeah I've been chewing over how to fix this for a while

@zx8
Copy link

@zx8 zx8 commented Apr 13, 2019

Related: #5571

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug
Projects
None yet
Development

No branches or pull requests

5 participants