Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valid path highlighting broken (containing variables) #5571

Closed
zx8 opened this issue Jan 22, 2019 · 3 comments
Closed

Valid path highlighting broken (containing variables) #5571

zx8 opened this issue Jan 22, 2019 · 3 comments
Assignees
@ridiculousfish
Labels
bug Something that's not working as intended regression Something that used to work, but was broken, especially between releases
Milestone
fish 3.1.0

Comments

@zx8
Copy link

zx8 commented Jan 22, 2019 •
edited
Loading

Similar to #5514

$ fish --version
fish, version 3.0.0-217-gb23403ee

Case 1

$SCRIPT_PATH/1.sh should not be highlighted as invalid/red:

image

Case 2 (edit: see #5571 (comment) this is not a bug)

$SCRIPT_PATH/1.sh should be underlined/valid as follows:

image

But instead is not:

image
@zanchey zanchey added this to the fish-future milestone Jan 22, 2019
@zx8
Copy link
Author

zx8 commented Jan 22, 2019 •
edited
Loading

@zanchey I think this is actually a bug/regression? Very likely the same root cause as #5514

[EDIT] Case 1 is a regression, Case 2 is not:

image

@faho faho added bug Something that's not working as intended regression Something that used to work, but was broken, especially between releases and removed enhancement labels Jan 23, 2019
@faho faho modified the milestones: fish-future, fish 3.1.0 Jan 23, 2019
@ridiculousfish ridiculousfish self-assigned this Jan 23, 2019
@ridiculousfish
Copy link
Member

Yeah we aren't providing the entire variable set to highlighting. I broke it and will fix it.

@floam floam modified the milestones: fish 3.1.0, fish 3.0.1 Jan 25, 2019
@ridiculousfish
Copy link
Member

ridiculousfish commented Jan 25, 2019 •
edited
Loading

Good instinct but this is not broken in 3.0.0, only in master, so there's no need for a 3.0.1 fix.

@ridiculousfish ridiculousfish modified the milestones: fish 3.0.1, fish 3.1.0 Jan 25, 2019
@floam floam mentioned this issue Apr 8, 2019
Open
@zx8 zx8 mentioned this issue Apr 13, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ridiculousfish ridiculousfish

Labels
bug Something that's not working as intended regression Something that used to work, but was broken, especially between releases
Projects
None yet
Milestone
fish 3.1.0
Development

No branches or pull requests
5 participants
@floam @zanchey @ridiculousfish @faho @zx8