Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conf.d load order changed in 3.1.0 release #6593

Closed
tough-griff opened this issue Feb 13, 2020 · 5 comments
Closed

conf.d load order changed in 3.1.0 release #6593

tough-griff opened this issue Feb 13, 2020 · 5 comments
Labels
bug Something that's not working as intended regression Something that used to work, but was broken, especially between releases
Milestone
fish 3.1.1

Comments

@tough-griff
Copy link

Prior to updating to fish 3.1.0, I was able to predict the load order of files in my .config/fish/conf.d/ folder. I designed this folder with a ___env.fish file to set some global exported variables that could be shared among configuration files that would load later.

Now, after updating to fish 3.1.0, the __env.fish file loads last instead of first.
@faho
Copy link
Member

faho commented Feb 13, 2020

Yeah, I can reproduce. The order of globs changed.

As a workaround I recommend calling the file 00-env.fish instead, as numbers will be much more stable, also across locales and such.

@faho faho added bug Something that's not working as intended regression Something that used to work, but was broken, especially between releases labels Feb 13, 2020
@faho faho added this to the fish 3.1.1 milestone Feb 13, 2020
@zanchey
Copy link
Member

zanchey commented Feb 14, 2020

This is due to 74a22ff discussed in #5634 (comment)

@zanchey
Copy link
Member

zanchey commented Feb 14, 2020

I'm not sure that the order of globs is guaranteed anywhere, though I agree that it's a bit obnoxious for it to change.

@faho
Copy link
Member

faho commented Feb 14, 2020

I feel like the glob order should be uncoupled from the file completion order.

@faho faho closed this as completed in f053cd2 Feb 14, 2020
@faho
Copy link
Member

faho commented Feb 14, 2020

Yeah, I've now reverted the changes to glob ordering since 3.1, but only to glob ordering. It's now uncoupled from completion ordering, so we can change that to our heart's content.

reitermarkus added a commit to reitermarkus/dotfiles that referenced this issue Feb 18, 2020
@reitermarkus
Change environment file name.
22497fa 
fish-shell/fish-shell#6593
zanchey pushed a commit that referenced this issue Feb 22, 2020
@faho @zanchey
Return glob ordering to pre-3.1 state
cecb0eb 
Glob ordering is used in a variety of places, including figuring out
conf.d and really needs to be stable.

Other ordering, like completions, is really just cosmetic and can
change if it makes for a nicer experience.

So we uncouple it by copying the wcsfilecmp from 3.0.2, which will
return the ordering to what it was in that release.

Fixes #6593

(cherry picked from commit f053cd2)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something that's not working as intended regression Something that used to work, but was broken, especially between releases
Projects
None yet
Milestone
fish 3.1.1
Development

No branches or pull requests
3 participants
@zanchey @tough-griff @faho