fish_indent: Remove useless quotes #6722
Conversation
src/fish_indent.cpp
Outdated
| // If no non-alphanumeric char is left, use the unescaped version. | ||
| // This can be extended to other characters, but giving the precise list is tough, | ||
| // can change over time (see "^", "%" and "?", in some cases "{}") and it just makes people feel more at ease. | ||
| if (std::find_if_not(unescaped.begin(), unescaped.end(), fish_iswalnum) == unescaped.end() && !unescaped.empty()) { |
There was a problem hiding this comment.
Can we add just _ and - to the allowed characters? Since they are commonly used for compound names.
There was a problem hiding this comment.
I'd like it if we could anchor this to some other character set. I don't think we have a set of "safe" characters anywhere. We could also pick valid variable names, which is this plus "_", but not "-".
Note that this would have real impact on how our completions format - there are some that have "kebab-case" commands.
Or we just declare a random set of valid characters, that wouldn't be too awful.
There was a problem hiding this comment.
Okay, I pushed an additional list of "-", "_" and "/". To show the difference I added another commit just with those changes, but I'll remove that when merging.
This tries to see if quotes guard some expansion from happening. If it
detects a "weird" character it'll leave the quotes in place, even in
some cases where it might not trigger.
So
for i in 'c' 'color'
turns into
for i in c color
The rationale here is that these quotes are useless, wasting
space (and line length), but more importantly that they are
superstitions. They don't do anything, but look like they do.
The counter argument is that they can be kept in case of later
changes, or that they make the intent clear - "this is supposed to be
a string we pass".
This is sometimes not wanted, like in the case of fish_indent.
This adds "_", "-" and "/" as characters for words we strip quotes from. The list is admittedly a tad arbitrary.
faho
force-pushed
the
indent-useless-quotes
branch
from
fb40d5b
to
945654c
Compare
Description
This changes fish_indent so that it strips quotes where they don't have any use.
In particular what it will do is turn this
into this:
As you can see it currently doesn't handle everything but instead tries unquoting and if that only leaves alphanumeric characters it leaves the quotes off.
(I initially tried a complicated scheme in which I'd try unescaping twice to see if anything changes, but that had issues, in particular with chars like
^or%that might only be special some of the time).TODOs: