Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

help command uses openvt's open instead of xdg-open when DISPLAY is unset #6739

Closed
ThomasAH opened this issue Mar 12, 2020 · 1 comment
Closed

help command uses openvt's open instead of xdg-open when DISPLAY is unset #6739

ThomasAH opened this issue Mar 12, 2020 · 1 comment
Labels
bug Something that's not working as intended
Milestone
fish 3.1.1

Comments

@ThomasAH
Copy link

fish 3.1.0 on Debian stretch.

Issue #5756 is not fixed when DISPLAY is not set, because help.fish contains:

            else if type -q xdg-open; and set -q -x DISPLAY
                set fish_browser xdg-open
            end

In this case /bin/open (the symlink to /bin/openvt on Debian stretch) is used, which results in the unhelpful error message "Couldn't get a file descriptor referring to the console".

Workaround: set BROWSER xdg-open
(or maybe use dpkg-divert to hide the open command, but I haven't tested that)

xdg-open works fine even without a DISPLAY variable, in my case it opens the help in "links".

Debian buster does no longer have /bin/open, so the error does not occur there.
@faho faho closed this as completed in 5ab1e2d Mar 12, 2020
faho added a commit that referenced this issue Mar 12, 2020
@faho
help: Always use xdg-open if available
62525ab 
Even if $DISPLAY is unset, xdg-open can be useful, and on systems that
have xdg-open, "open" is most likely some god awful outdated thing
called "openvt" elsewhere.

Fixes #6739

[ci skip]
@faho
Copy link
Member

faho commented Mar 12, 2020

Yeah, sure, let's just skip the $DISPLAY check.

Fixed on master and 3.1.1 (62525ab)

@faho faho added the bug Something that's not working as intended label Mar 12, 2020
@faho faho added this to the fish 3.1.1 milestone Mar 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something that's not working as intended
Projects
None yet
Milestone
fish 3.1.1
Development

No branches or pull requests
2 participants
@ThomasAH @faho